Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor style touch on dashboard page #11570

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Nov 5, 2020

SUMMARY

A couple of small styling fixes for the dashboard page.

  1. Change tabs back to regular case: in general, user inputs should not be uppercase because if users really want to use uppercase, they can easily do that themself. Leaving uppercase labels to native UI elements also makes them more special and utility-like.
  2. Adjust the margins in filter labels. Currently the text is kind of all over the place.
  3. Change the cursor for dashboard tabs in editing state from pointer (indicating a button) to text (indicating this is an input field).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

On Explore page:

Snip20201104_28

TEST PLAN

Manually check the style works.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

cc @rusackas @kgabryje

@ktmud ktmud changed the title fix: minor style touch on dashboards fix: minor style touch on dashboard page Nov 5, 2020
@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #11570 (54dc30f) into master (24ba530) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11570   +/-   ##
=======================================
  Coverage   62.26%   62.26%           
=======================================
  Files         873      873           
  Lines       42256    42256           
  Branches     3961     3961           
=======================================
  Hits        26310    26310           
  Misses      15766    15766           
  Partials      180      180           
Flag Coverage Δ
javascript 62.83% <ø> (ø)
python 61.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/dashboard/components/gridComponents/Tabs.jsx 65.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ba530...54dc30f. Read the comment docs.

@ktmud ktmud force-pushed the dashboard-label--normal-case branch from d7178bd to 54dc30f Compare November 9, 2020 03:38
@ktmud ktmud merged commit 92a9acd into apache:master Nov 9, 2020
@ktmud ktmud deleted the dashboard-label--normal-case branch November 9, 2020 05:27
@ktmud
Copy link
Member Author

ktmud commented Nov 12, 2020

User testimony of why this kind of little things matter!

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants