--WIP-- add faves/starred things to /welcome #1169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 22, 2016 00:45
ascott
commented
Sep 22, 2016
| faves: PropTypes.array | ||
| }; | ||
|
|
||
| const defaultProps = { |
There was a problem hiding this comment.
need to replace these default props with real data.
ascott
commented
Sep 22, 2016
| import React, { PropTypes } from 'react'; | ||
|
|
||
| const propTypes = { | ||
| faves: PropTypes.array |
There was a problem hiding this comment.
this should be PropTypes.array.isRequired
ascott
commented
Sep 22, 2016
| @@ -1918,6 +1918,14 @@ class FavStar(Model): | |||
| obj_id = Column(Integer) | |||
| dttm = Column(DateTime, default=func.now()) | |||
|
|
|||
| """todo(alanna) - return name of slice or dashboard with these props""" | |||
There was a problem hiding this comment.
what's the best way to query each starred item for it's name?
ascott
commented
Sep 22, 2016
| return self.render_template( | ||
| 'caravel/welcome.html', | ||
| utils=utils, | ||
| faves=faves |
There was a problem hiding this comment.
faves returns an array with json with us prepended to the name. [{u'class_name': u'Dashboard', u'user_id': 1, u'obj_id': 2}, {u'class_name': u'Dashboard', u'user_id': 1, u'obj_id': 1}]
need to figure out how to fix this. do we have a pattern for sending model data to the view as json?
There was a problem hiding this comment.
can you point me in the right direction here @mistercrunch?
This was referenced Jul 17, 2020
Open
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
plz review @mistercrunch @bkyryliuk @vera-liu @elibrumbaugh
there are some open questions so would love your feedback. thx!