-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new reports scheduler #11711
Merged
dpgaspar
merged 17 commits into
apache:master
from
preset-io:feat/reports-models-scheduler
Nov 25, 2020
Merged
feat: new reports scheduler #11711
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
bb7dea9
feat(reports): scheduler and delivery system
dpgaspar 136d4ae
Merge branch 'master' into feat/reports-models-scheduler
dpgaspar b352280
working version
dpgaspar d2f0d05
add missing license
dpgaspar cfa92eb
lint
dpgaspar 2ff6de2
improvements and fix grace_period
dpgaspar 0e1f081
lint
dpgaspar 198cd75
add tests and fix bugs
dpgaspar 91751aa
test
dpgaspar 260838b
test
dpgaspar 32e40e3
more tests
dpgaspar f78dd9e
fix report API test
dpgaspar 44923b4
test MySQL test fail
dpgaspar 89abae3
delete-orphan
dpgaspar 094a3c7
fix MySQL tests
dpgaspar c5ccd12
address comments
dpgaspar d0e3770
lint
dpgaspar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
import json | ||
import logging | ||
from operator import eq, ge, gt, le, lt, ne | ||
from typing import Optional | ||
|
||
import numpy as np | ||
from flask_babel import lazy_gettext as _ | ||
|
||
from superset import jinja_context | ||
from superset.commands.base import BaseCommand | ||
from superset.models.reports import ReportSchedule, ReportScheduleValidatorType | ||
from superset.reports.commands.exceptions import ( | ||
AlertQueryInvalidTypeError, | ||
AlertQueryMultipleColumnsError, | ||
AlertQueryMultipleRowsError, | ||
) | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
OPERATOR_FUNCTIONS = {">=": ge, ">": gt, "<=": le, "<": lt, "==": eq, "!=": ne} | ||
|
||
|
||
class AlertCommand(BaseCommand): | ||
def __init__(self, report_schedule: ReportSchedule): | ||
self._report_schedule = report_schedule | ||
self._result: Optional[float] = None | ||
|
||
def run(self) -> bool: | ||
self.validate() | ||
|
||
if self._report_schedule.validator_type == ReportScheduleValidatorType.NOT_NULL: | ||
self._report_schedule.last_value_row_json = self._result | ||
return self._result not in (0, None, np.nan) | ||
self._report_schedule.last_value = self._result | ||
operator = json.loads(self._report_schedule.validator_config_json)["op"] | ||
threshold = json.loads(self._report_schedule.validator_config_json)["threshold"] | ||
return OPERATOR_FUNCTIONS[operator](self._result, threshold) | ||
|
||
def _validate_not_null(self, rows: np.recarray) -> None: | ||
self._result = rows[0][1] | ||
|
||
def _validate_operator(self, rows: np.recarray) -> None: | ||
# check if query return more then one row | ||
if len(rows) > 1: | ||
raise AlertQueryMultipleRowsError( | ||
message=_( | ||
"Alert query returned more then one row. %s rows returned" | ||
% len(rows), | ||
) | ||
) | ||
# check if query returned more then one column | ||
if len(rows[0]) > 2: | ||
raise AlertQueryMultipleColumnsError( | ||
_( | ||
"Alert query returned more then one column. %s columns returned" | ||
% len(rows[0]) | ||
) | ||
) | ||
if rows[0][1] is None: | ||
return | ||
try: | ||
# Check if it's float or if we can convert it | ||
self._result = float(rows[0][1]) | ||
return | ||
except (AssertionError, TypeError, ValueError): | ||
raise AlertQueryInvalidTypeError() | ||
|
||
def validate(self) -> None: | ||
""" | ||
Validate the query result as a Pandas DataFrame | ||
""" | ||
sql_template = jinja_context.get_template_processor( | ||
database=self._report_schedule.database | ||
) | ||
rendered_sql = sql_template.process_template(self._report_schedule.sql) | ||
df = self._report_schedule.database.get_df(rendered_sql) | ||
|
||
if df.empty: | ||
return | ||
rows = df.to_records() | ||
if self._report_schedule.validator_type == ReportScheduleValidatorType.NOT_NULL: | ||
self._validate_not_null(rows) | ||
return | ||
self._validate_operator(rows) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct if the result is a float, but if it's a row or set of rows this should behave differently.