feat(explore): Time picker enhancement follow up #12208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12208 +/- ##
==========================================
+ Coverage 63.00% 67.18% +4.17%
==========================================
Files 996 1002 +6
Lines 49192 49229 +37
Branches 4993 5000 +7
==========================================
+ Hits 30995 33074 +2079
+ Misses 17997 16032 -1965
+ Partials 200 123 -77
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
force-pushed
the
improvement_time_picker
branch
from
231c3ca
to
327b55b
Compare
|
Please take a care of flaky tests |
ktmud
approved these changes
Jan 4, 2021
| const iso8601 = String.raw`\d{4}-\d\d-\d\dT\d\d:\d\d:\d\d(?:\.\d+)?(?:(?:[+-]\d\d:\d\d)|Z)?`; | ||
| const datetimeConstant = String.raw`TODAY|NOW`; | ||
| const grainValue = String.raw`[+-]?[1-9][0-9]*`; | ||
| const grain = String.raw`YEAR|QUARTER|MONTH|WEEK|DAY|HOUR|MINUTE|SECOND`; |
There was a problem hiding this comment.
Any reason to not use UPPER_CASE for these constants?
There was a problem hiding this comment.
Use UPPER CASE just for constant looks well. In fact, case insensitive in python datetime expression parser, in other words 'YEAR' == 'year' == 'YEAR' for backend datetime parser.
superset-frontend/src/explore/components/controls/DateFilterControl/AdvancedFrame.tsx
Outdated
Show resolved
Hide resolved
zhaoyongjie
force-pushed
the
improvement_time_picker
branch
from
970f109
to
4e7a391
Compare
I will keep an eye on this flaky test |
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
* refactor layout * WIP * fix typing * styling * fix lint * frontend IT * rename variable * added quarter * typos * refine code structure
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 7, 2021
* refactor layout * WIP * fix typing * styling * fix lint * frontend IT * rename variable * added quarter * typos * refine code structure
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
follow up PR
UI Design
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
Last
Previous
Custom
Advanced
No filter
TEST PLAN
Added cypress for the time picker
ADDITIONAL INFORMATION