Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert devtool alert #1238

Merged
merged 1 commit into from
Oct 3, 2016
Merged

revert devtool alert #1238

merged 1 commit into from
Oct 3, 2016

Conversation

vera-liu
Copy link
Contributor

@vera-liu vera-liu commented Oct 3, 2016

Reverting this change: https://github.com/airbnb/caravel/pull/1228 since our linter doesn't allow console code.
@bkyryliuk @ascott @mistercrunch

@bkyryliuk
Copy link
Member

thanks, LGTM !

@vera-liu vera-liu merged commit d8638db into apache:master Oct 3, 2016
@ascott
Copy link
Contributor

ascott commented Oct 5, 2016

we could get around the linter issue by adding /*eslint-disable no-console */ just above the log. i think this log is helpful since errors are thrown in dev if redux dev tools are not installed.

@zalmoxisus zalmoxisus mentioned this pull request Oct 6, 2016
Merged
@vera-liu vera-liu deleted the vliu_revert_devtool_alert branch November 1, 2016 19:05
@m-ajay m-ajay mentioned this pull request Nov 5, 2022
Open
@m-ajay m-ajay mentioned this pull request Dec 26, 2022
Open
@m-ajay m-ajay mentioned this pull request Nov 28, 2023
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vera-liu @bkyryliuk @ascott @mistercrunch