-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass correct report_format #16306
fix: pass correct report_format #16306
Conversation
3ab0e46
to
199fe9f
Compare
Codecov Report
@@ Coverage Diff @@
## master #16306 +/- ##
==========================================
- Coverage 76.65% 76.65% -0.01%
==========================================
Files 999 999
Lines 53394 53397 +3
Branches 6817 6819 +2
==========================================
+ Hits 40929 40931 +2
- Misses 12228 12229 +1
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@betodealmeida if this looks good to you and passes CI, feel free to merge if you need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
🏷️ 2021.31.10 |
🏷️ 2021.31 |
(cherry picked from commit 4960b5e)
SUMMARY
We were passing "TEXT" for all report_types and it was breaking dashboards which require a PNG report type. The result was that we were receiving emails with no image for dashboards.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TESTING INSTRUCTIONS
create a report from a dashboard page and verify that the email has a png image in it.
unit tests are currently in review in a separate pr. Will update them to add this functionality.
ADDITIONAL INFORMATION