Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass correct report_format #16306

Merged

Conversation

eschutho
Copy link
Member

SUMMARY

We were passing "TEXT" for all report_types and it was breaking dashboards which require a PNG report type. The result was that we were receiving emails with no image for dashboards.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
Screenshot_8_17_21__5_20_PM
after:
All_Mail__26_636_messages__19_366_unread_

TESTING INSTRUCTIONS

create a report from a dashboard page and verify that the email has a png image in it.
unit tests are currently in review in a separate pr. Will update them to add this functionality.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/fix-blank-png-report branch from 3ab0e46 to 199fe9f Compare August 18, 2021 00:38
@eschutho eschutho added need:merge The PR is ready to be merged and removed need:merge The PR is ready to be merged labels Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #16306 (199fe9f) into master (7a284bb) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16306      +/-   ##
==========================================
- Coverage   76.65%   76.65%   -0.01%     
==========================================
  Files         999      999              
  Lines       53394    53397       +3     
  Branches     6817     6819       +2     
==========================================
+ Hits        40929    40931       +2     
- Misses      12228    12229       +1     
  Partials      237      237              
Flag Coverage Δ
javascript 70.77% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ReportModal/index.tsx 73.46% <87.50%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a284bb...199fe9f. Read the comment docs.

@eschutho
Copy link
Member Author

@betodealmeida if this looks good to you and passes CI, feel free to merge if you need it.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Aug 18, 2021
@betodealmeida betodealmeida merged commit 4960b5e into apache:master Aug 18, 2021
betodealmeida pushed a commit to preset-io/superset that referenced this pull request Aug 18, 2021
betodealmeida pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
@stevenuray
Copy link

🏷️ 2021.31.10

@stevenuray
Copy link

🏷️ 2021.31

henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset:2021.31 preset:2021.31.10 preset-io size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants