fix: Apply custom label colors in the Dashboard immediately

[geido]

SUMMARY

This PR fixes an issue with the custom label colors not being applied on the fly.

BEFORE

Please check issue #11677

AFTER

Test.dashboard.2.mp4

TESTING INSTRUCTIONS

1. Open a Dashboard
2. Go to "Edit properties"
3. Got to "Advanced"
4. Change the label colors
5. Save and observe the behavior

ADDITIONAL INFORMATION

• Has associated issue: Fixes [dashboard properties] metadata saving behavior on SAVE #11677
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16637 (805bf58) into master (a6173f1) will increase coverage by 0.00%.
The diff coverage is 82.35%.

❗ Current head 805bf58 differs from pull request most recent head 3f9ea84. Consider uploading reports for the commit 3f9ea84 to get more accurate results

@@           Coverage Diff           @@
##           master   #16637   +/-   ##
=======================================
  Coverage   76.92%   76.92%           
=======================================
  Files        1031     1031           
  Lines       55151    55165   +14     
  Branches     7498     7504    +6     
=======================================
+ Hits        42426    42438   +12     
- Misses      12473    12474    +1     
- Partials      252      253    +1     

Flag	Coverage Δ
javascript	70.89% <82.35%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/chart/Chart.jsx	43.33% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx	36.70% <0.00%> (-0.48%)	⬇️
.../src/dashboard/components/gridComponents/Chart.jsx	80.37% <ø> (ø)
...shboard/util/charts/getFormDataWithExtraFilters.ts	83.87% <50.00%> (ø)
...et-frontend/src/dashboard/actions/dashboardInfo.ts	60.00% <88.88%> (+12.94%)	⬆️
...perset-frontend/src/dashboard/containers/Chart.jsx	93.75% <100.00%> (+1.44%)	⬆️
...uperset-frontend/src/explore/exploreUtils/index.js	66.87% <100.00%> (+0.41%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6173f1...3f9ea84. Read the comment docs.

[villebro]

A few minor non-blocking comments. Ping @kgabryje - I wonder if this will reintroduce colors into the URL that was removed in #16621 ?

[kgabryje]

@geido @villebro Unfortunately it seems that this change might contribute even more to the problems with very long explore URLs.
I tested it using Slack dashboard and Messages per Channel chart.
This is the url from my local environment:

And this is the one from testenv spinned for this PR:

[geido]

Thanks for spotting this issue @villebro @kgabryje . I believe this can be handled differently to avoid the consequences with the URL length. I'll work on that and ping you again

[geido]

@kgabryje @villebro what I found is that even in the current implementation the label_colors should be polluting the URL but in some cases the scale is just returning empty, that's the reason why it seems that the URL isn't affected.
The correct solution here is to remove the label_colors from the formData and pass them directly to the chart so that the URL won't ever be polluted. This is the change that I just did.

It remains the problem of how we pass the label colors to the chart when coming from the Dashboard to Explore. However, that is a much bigger problem and will need to be tackled in a separate PR.

[kgabryje]

Are you sure that label_colors were removed from URL? I went from Slack dashboard to Messages per Channel chart in Explore and it seems that label colors are included in URL.
On the left is my localhost built on the latest master, on the right test env from this PR

[geido]

@kgabryje you are perfectly right but this was a funny one. Basically, the reason why label_colors do not pollute the URL on master is due to that bug I mentioned before. The bug was removed with my changes and I did not notice that I had to forcefully remove the label_colors from the URL as well, which is what I just did in my latest changes. It should be good to go now I hope!

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://34.212.207.74:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

Closing this in favour of #17089 which is going to cover all the other cases

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.