Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade babel #16885

Merged
merged 5 commits into from
Oct 5, 2021
Merged

chore: upgrade babel #16885

merged 5 commits into from
Oct 5, 2021

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Sep 29, 2021

SUMMARY

Upgrades versions of all babel libraries.

TESTING INSTRUCTIONS

This affects the entire js build, so technically if we want to be super rigorous we need to test all code paths 🤢 .

But the version bumps are all minor, so as long as CI is green there should be no special QA required.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #16885 (5ec05c0) into master (739d841) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16885      +/-   ##
==========================================
+ Coverage   76.92%   76.95%   +0.02%     
==========================================
  Files        1030     1030              
  Lines       55023    55213     +190     
  Branches     7463     7546      +83     
==========================================
+ Hits        42329    42491     +162     
- Misses      12441    12466      +25     
- Partials      253      256       +3     
Flag Coverage Δ
hive 81.44% <ø> (ø)
javascript 71.02% <ø> (+0.09%) ⬆️
mysql 81.83% <ø> (ø)
postgres 81.89% <ø> (ø)
presto 81.77% <ø> (+<0.01%) ⬆️
python 82.39% <ø> (+<0.01%) ⬆️
sqlite 81.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/dashboard/components/menu/HoverMenu.tsx 93.75% <0.00%> (-6.25%) ⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx 83.33% <0.00%> (-3.34%) ⬇️
...nd/src/dashboard/util/activeAllDashboardFilters.ts 89.28% <0.00%> (-3.31%) ⬇️
...nd/src/dashboard/components/nativeFilters/state.ts 74.54% <0.00%> (-0.46%) ⬇️
...d/src/explore/components/DatasourcePanel/index.tsx 74.22% <0.00%> (-0.27%) ⬇️
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 95.45% <0.00%> (-0.20%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 43.93% <0.00%> (-0.12%) ⬇️
.../src/explore/components/DataTableControl/index.tsx 98.00% <0.00%> (-0.04%) ⬇️
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 94.83% <0.00%> (-0.03%) ⬇️
superset-frontend/src/views/menu.tsx 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739d841...5ec05c0. Read the comment docs.

@villebro
Copy link
Member

This needs a rebase (I noticed when looking at the failed frontend tests that this was cut prior to bumping Node to v. 16)

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works well in testing, thanks so much for this work! 💯

@suddjian suddjian closed this Oct 5, 2021
@suddjian suddjian reopened this Oct 5, 2021
@suddjian suddjian merged commit 1cd0124 into master Oct 5, 2021
@suddjian suddjian deleted the babel-upgrade branch October 5, 2021 22:03
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* upgrade babel versions

* upgrade babel eslint parser

* fix test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* upgrade babel versions

* upgrade babel eslint parser

* fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants