test: Cypress 7.0.0 migration #16911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #16911 +/- ##
==========================================
+ Coverage 76.88% 76.92% +0.04%
==========================================
Files 1031 1031
Lines 55197 55197
Branches 7506 7506
==========================================
+ Hits 42436 42463 +27
+ Misses 12509 12482 -27
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
geido
reviewed
Sep 30, 2021
lyndsiWilliams
force-pushed
the
lyndsi/cypress-7-migration
branch
from
9f1db45
to
3b6dcb9
Compare
betodealmeida
requested changes
Oct 13, 2021
superset-frontend/cypress-base/cypress/integration/dashboard/controls.test.ts
Show resolved
Hide resolved
betodealmeida
approved these changes
Oct 14, 2021
eschutho
reviewed
Oct 15, 2021
| @@ -11,13 +11,13 @@ | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "@cypress/code-coverage": "^3.9.11", | |||
| "@superset-ui/core": "^0.18.4", | |||
| "@superset-ui/core": "^0.18.8", | |||
|
we're also missing some package-lock files. |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* Copied changes from original PR, minus package-lock.json files * Reverted command name change * Fixed package.json in superset-frontend * Test adjustments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR migrates Cypress to 7.x. Details for this process can be found here.
Note: There are 4 tests skipped in
dashboard/controls.test.ts,dashboard/filter.test.ts,dashboard/tabs.test.tsanddashboard/url_params.test.tsbecause they're breaking for reasons unrelated to my changes and I couldn't figure out how to fix them.TESTING INSTRUCTIONS
superset-frontend/package.jsonand observe the dev dependency:"@cypress/react": "^5.10.0"superset-frontend/cypress-base/package.jsonand observe the dependency:"@cypress/code-coverage": "^3.9.11"and dev dependency:"cypress": "^7.0.0"ADDITIONAL INFORMATION