Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(QueryContext): validation does not validate query_context metrics #16991

Closed
wants to merge 15 commits into from
Closed

fix(QueryContext): validation does not validate query_context metrics #16991

wants to merge 15 commits into from

Commits on Dec 14, 2021

  1. fix query_context validation does not validate sql metrics

    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    0249763 View commit details
    Browse the repository at this point in the history

  2. remove mark and clean small issue in query_context.py

    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    d3c16cf View commit details
    Browse the repository at this point in the history

  3. fix pr requested changes 

      - put new validation under FF
  - consistency with naming convention
  - remove global pylint disable
    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c553c16 View commit details
    Browse the repository at this point in the history

  4. fix: string format best practice 

    Co-authored-by: Ville Brofeldt <[email protected]>
    @amitmiran137 @villebro @ofekisr
    2 people authored and ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    d518b57 View commit details
    Browse the repository at this point in the history

  5. fix: string format best practice 

    Co-authored-by: Ville Brofeldt <[email protected]>
    @amitmiran137 @villebro @ofekisr
    2 people authored and ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    b918a09 View commit details
    Browse the repository at this point in the history

  6. fix failing unit tests

    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    ac3c0bb View commit details
    Browse the repository at this point in the history

  7. fix pr requested change

    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c7e4985 View commit details
    Browse the repository at this point in the history

  8. fix pre-commit and pylint

    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    9510bd6 View commit details
    Browse the repository at this point in the history

  9. add: integration tests

    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3d204e6 View commit details
    Browse the repository at this point in the history

  10. fix failed tests

    @ofekisr
    ofekisr committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    90ac808 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Merge branch 'upstream_master' into fix/sql_metric_access_validation 

    # Conflicts:
#	tests/integration_tests/charts/data/api_tests.py
    @ofekisr
    ofekisr committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    9d8d6f4 View commit details
    Browse the repository at this point in the history

  2. fix failed tests

    @ofekisr
    ofekisr committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    e6b9d49 View commit details
    Browse the repository at this point in the history

  3. fix failed tests

    @ofekisr
    ofekisr committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    7e61d28 View commit details
    Browse the repository at this point in the history

  4. fix failed tests

    @ofekisr
    ofekisr committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    c1a9c83 View commit details
    Browse the repository at this point in the history

  5. fix failed tests

    @ofekisr
    ofekisr committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    dd48e73 View commit details
    Browse the repository at this point in the history