Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vscode linter instructions to CONTRIBUTING.md #17045

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Oct 8, 2021

SUMMARY

Something in the updated eslint/babel config isn't able to function without this extra config, since the frontend code is not in the project root.

TESTING INSTRUCTIONS

@geido to verify the solution works.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #17045 (0278b0e) into master (a6173f1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17045      +/-   ##
==========================================
- Coverage   76.92%   76.92%   -0.01%     
==========================================
  Files        1031     1031              
  Lines       55151    55151              
  Branches     7498     7498              
==========================================
- Hits        42426    42424       -2     
- Misses      12473    12475       +2     
  Partials      252      252              
Flag Coverage Δ
hive 81.47% <ø> (ø)
javascript 70.88% <ø> (ø)
mysql 81.92% <ø> (ø)
postgres 81.93% <ø> (ø)
presto 81.79% <ø> (-0.01%) ⬇️
python 82.43% <ø> (-0.01%) ⬇️
sqlite 81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 89.95% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6173f1...0278b0e. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finding the solution to this annoying problem!

@suddjian suddjian merged commit c734035 into master Oct 11, 2021
@suddjian suddjian deleted the eslint-vscode-doc branch October 11, 2021 22:16
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants