Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove supersetTheme with withTheme #17069

Merged
merged 10 commits into from
Oct 27, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr removes the supersetTheme with withTheme component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2021-10-11.at.9.40.39.PM.mov

after
https://user-images.githubusercontent.com/17326228/136892210-bea4877b-8166-4714-9753-64e92af57b23.mov

TESTING INSTRUCTIONS

Go to any chart and go to the datasource panel and click on edit datasource. Check modal looks identical to original.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/L and removed size/S labels Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #17069 (23c5ed3) into master (cd9e994) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17069      +/-   ##
==========================================
+ Coverage   76.91%   77.00%   +0.09%     
==========================================
  Files        1039     1038       -1     
  Lines       55566    55612      +46     
  Branches     7570     7585      +15     
==========================================
+ Hits        42738    42824      +86     
+ Misses      12578    12538      -40     
  Partials      250      250              
Flag Coverage Δ
javascript 71.13% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Datasource/DatasourceEditor.jsx 76.09% <100.00%> (+3.98%) ⬆️
...erset-frontend/src/components/Pagination/index.tsx 72.72% <0.00%> (-27.28%) ⬇️
...nativeFilters/FiltersConfigModal/Footer/Footer.tsx 90.90% <0.00%> (-9.10%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 68.30% <0.00%> (-0.41%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 74.28% <0.00%> (-0.25%) ⬇️
...frontend/src/components/DatabaseSelector/index.tsx 95.00% <0.00%> (-0.13%) ⬇️
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx 96.07% <0.00%> (-0.08%) ⬇️
...frontend/src/components/TimezoneSelector/index.tsx 97.72% <0.00%> (-0.06%) ⬇️
superset-frontend/src/views/menu.tsx 0.00% <0.00%> (ø)
...et-frontend/src/filters/components/Select/types.ts 100.00% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9e994...23c5ed3. Read the comment docs.

@pkdotson pkdotson merged commit 93f59e0 into apache:master Oct 27, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants