Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Make color scheme optional #17357

Merged
merged 1 commit into from
Nov 5, 2021
Merged

fix(Dashboard): Make color scheme optional #17357

merged 1 commit into from
Nov 5, 2021

Conversation

geido
Copy link
Member

@geido geido commented Nov 5, 2021

SUMMARY

It makes the color scheme optional when saving a Dashboard and adds a test case

BEFORE

Test.mp4

AFTER

untitled.dashb.3.mp4

TESTING INSTRUCTIONS

  1. Create a new Dashboard
  2. Leave the color scheme empty
  3. Make sure you can save

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #17357 (db86dd4) into master (fa51b32) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17357      +/-   ##
==========================================
- Coverage   77.14%   77.13%   -0.01%     
==========================================
  Files        1036     1036              
  Lines       55757    55757              
  Branches     7628     7628              
==========================================
- Hits        43011    43010       -1     
- Misses      12490    12491       +1     
  Partials      256      256              
Flag Coverage Δ
javascript 71.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/PropertiesModal/index.jsx 83.21% <100.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.13% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa51b32...db86dd4. Read the comment docs.

@geido geido merged commit ee7c34b into apache:master Nov 5, 2021
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Nov 5, 2021
@sadpandajoe
Copy link
Member

🏷️ 2021.44

AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.44 size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants