fix(sqllab): Query limit dropdown number breaks to separate lines #17382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17382 +/- ##
==========================================
- Coverage 77.07% 77.02% -0.05%
==========================================
Files 1036 1038 +2
Lines 55756 56021 +265
Branches 7630 7735 +105
==========================================
+ Hits 42972 43150 +178
- Misses 12529 12613 +84
- Partials 255 258 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -125,6 +125,10 @@ const StyledToolbar = styled.div` | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .limitDropdown { | |||
| width: max-content; | |||
There was a problem hiding this comment.
this is great! Super small nit, but white-space: nowrap may be more explicit here. You're saying "don't wrap on the white space", rather than "make the width of the element match the content." With white-spaceif you wanted to change the width later and make it larger, you still can.
There was a problem hiding this comment.
That's a lot safer of a method, thanks! Fixed in this commit.
…7382) * Limit break fixed * Used white-space: nowrap instead of width: max-content
mistercrunch
added
🏷️ bot
SUMMARY
The query limit dropdown number in SQL Lab editor would break into separate lines when the screen was at smaller widths and the number is "1 000" or higher. This is corrected by giving the number result
white-space: nowrap.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION