Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Notify user of custom label colors and related Dashboard color scheme #17422

Merged
merged 8 commits into from
Nov 16, 2021
Merged

chore: Notify user of custom label colors and related Dashboard color scheme #17422

merged 8 commits into from
Nov 16, 2021

Conversation

geido
Copy link
Member

@geido geido commented Nov 12, 2021

SUMMARY

This PR:

  • Adds the ability to notify the user about custom label colors used in a Dashboard
  • Adds the ability to inform the user when a chart in Explore is having a dashboard context, thus the color scheme will be inherited from the dashboard.
  • Adds some test cases for the ColorSchemeControl which had none before
  • Fixes [Explore] Linear color scheme options do not work  #17318

SUPERSET-UI PR

Requires apache-superset/superset-ui#1467 to be merged to function fully

AFTER DASHBOARD

untitled.dashb.mp4

AFTER EXPLORE

DEV.Vaccine.Ca.mp4

TESTING INSTRUCTIONS

  1. Open a Dashboard
  2. Set a color scheme
  3. Add custom label colors
  4. Make sure the color scheme alerts you of custom label colors in use
  5. Visit a chart
  6. Make sure the color scheme cannot be changed in Explore

ADDITIONAL INFORMATION

  • Has associated issue: [Explore] Linear color scheme options do not work  #17318
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137
Copy link
Member

This is great 👌

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion, looks great!

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #17422 (4827e78) into master (9ce6b7d) will increase coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17422      +/-   ##
==========================================
+ Coverage   76.96%   76.97%   +0.01%     
==========================================
  Files        1041     1041              
  Lines       56063    56096      +33     
  Branches     7738     7749      +11     
==========================================
+ Hits        43147    43179      +32     
- Misses      12658    12659       +1     
  Partials      258      258              
Flag Coverage Δ
javascript 71.25% <93.75%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/components/controls/ColorSchemeControl/index.jsx 72.22% <90.32%> (ø)
...dashboard/components/ColorSchemeControlWrapper.jsx 81.25% <100.00%> (ø)
...src/dashboard/components/PropertiesModal/index.jsx 85.23% <100.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce6b7d...4827e78. Read the comment docs.

@geido
Copy link
Member Author

geido commented Nov 12, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.209.144.65:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit c2d8b0e into apache:master Nov 16, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
… scheme (#17422)

* Add alert for custom label colors

* Fix duplicate linear scheme

* Implement dashboard alert

* Remove trailing space

* Update Cypress

* Simplify check
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Explore] Linear color scheme options do not work
4 participants