Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(monorepo): relocate deckgl to Superset #17596

Merged
merged 14 commits into from
Dec 9, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Nov 30, 2021

SUMMARY

This PR move Deckgl to plugins directory

  1. move legacy-preset-chart-deckgl to plugins directory
  2. move storybook to packages/superset-ui-demo/stories/plugins
  3. add tsconfig.json into package
  4. refactor storybook of Deckgl
  5. refactor src/factory.jsx to typescript
  6. remove legacy-preset-chart-deckgl from jest.config.js(in order to mapping this plugin for test)
  7. change controlPanel to typescript
  8. fix lint/type/test
  9. add Apache License

TESTING INSTRUCTIONS

  1. pass all steps of CI
  2. manually test in local environment

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie force-pushed the monorepo_deckgl branch 3 times, most recently from 413bc56 to 2301897 Compare December 1, 2021 16:39
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #17596 (dc7ffd7) into master (d7e3a60) will decrease coverage by 0.81%.
The diff coverage is 53.14%.

❗ Current head dc7ffd7 differs from pull request most recent head 2768ead. Consider uploading reports for the commit 2768ead to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17596      +/-   ##
==========================================
- Coverage   68.59%   67.77%   -0.82%     
==========================================
  Files        1588     1657      +69     
  Lines       64948    66291    +1343     
  Branches     6963     7146     +183     
==========================================
+ Hits        44548    44932     +384     
- Misses      18510    19470     +960     
+ Partials     1890     1889       -1     
Flag Coverage Δ
javascript 55.99% <41.17%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 91.30% <ø> (ø)
...set-chart-deckgl/src/AnimatableDeckGLContainer.jsx 0.00% <ø> (ø)
...et-chart-deckgl/src/CategoricalDeckGLContainer.jsx 0.00% <0.00%> (ø)
...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx 0.00% <0.00%> (ø)
...ins/legacy-preset-chart-deckgl/src/Multi/Multi.jsx 0.00% <0.00%> (ø)
...gacy-preset-chart-deckgl/src/Multi/controlPanel.js 0.00% <ø> (ø)
...gins/legacy-preset-chart-deckgl/src/Multi/index.js 66.66% <ø> (ø)
...gins/legacy-preset-chart-deckgl/src/TooltipRow.jsx 0.00% <ø> (ø)
...t-deckgl/src/components/BootstrapSliderWrapper.jsx 0.00% <ø> (ø)
...gacy-preset-chart-deckgl/src/components/Legend.jsx 0.00% <0.00%> (ø)
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e3a60...2768ead. Read the comment docs.

@stephenLYZ
Copy link
Member

LGTM

@kgabryje
Copy link
Member

kgabryje commented Dec 2, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

@kgabryje Ephemeral environment spinning up at http://54.214.111.155:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

import { SuperChart } from '@superset-ui/core';
import { ArcChartPlugin } from '@superset-ui/legacy-preset-chart-deckgl';
import payload from './payload';
import dummyDatasource from '../../../../shared/dummyDatasource';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: can we simplify this import? Maybe by setting a base path in tsconfig.json to storybook? Then we could import like import dummyDatasource from 'storybook/shared/dummyDatasource'; WDYT?

Copy link
Member

@kgabryje kgabryje Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(comment also applies to other files below that import dummyDatasource like that)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The absolute import depends on how to locate the storybook/shared module. (Maybe needed module alias in somewhere).

so relative import is straightforward here.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 04e3cfa into apache:master Dec 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants