Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy-plugin-chart-calendar): fix timestamp timezone in Calendar #17664

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 6, 2021

SUMMARY

Previously, the tooltips in Calendar Heatmap chart where displaying the date with user's local timezone applied. So for instance, if the query returned a date "2015-01-01 00:00:00", for a user in Poland the tooltip would be "2014-12-31 23:00:00" because of the timezone.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

  1. Create a Calendar Heatmap chart
  2. Verify that the dates in the calendar are UTC

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @junlincc

Internal: https://app.shortcut.com/preset/story/32292/fix-timezone-bug-on-cal-heatmap

@kgabryje
Copy link
Member Author

kgabryje commented Dec 6, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@kgabryje Ephemeral environment spinning up at http://34.222.48.144:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #17664 (a77f061) into master (07e8837) will increase coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17664      +/-   ##
==========================================
+ Coverage   68.76%   68.78%   +0.01%     
==========================================
  Files        1596     1597       +1     
  Lines       65221    65222       +1     
  Branches     6949     6950       +1     
==========================================
+ Hits        44849    44862      +13     
+ Misses      18489    18475      -14     
- Partials     1883     1885       +2     
Flag Coverage Δ
javascript 57.46% <25.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <0.00%> (ø)
...legacy-plugin-chart-calendar/src/transformProps.js 0.00% <0.00%> (ø)
.../plugins/legacy-plugin-chart-calendar/src/utils.ts 40.00% <40.00%> (ø)
...src/components/FilterableTable/FilterableTable.tsx 72.31% <0.00%> (+5.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e8837...a77f061. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, thanks so much for squashing this annoying bug that's practically always been there! 🐛 Just one thought: should we start relocating viz plugin tests next to the code in the source folders, like we're doing on the frontend side of the codebase?

@kgabryje kgabryje merged commit e660ea2 into apache:master Dec 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants