Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alembic): Making Alembic logger config optional #17774

Merged
merged 2 commits into from
Dec 16, 2021
Merged

fix(alembic): Making Alembic logger config optional #17774

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a9807d
Making Alembic logger config optional
craig-rueda Dec 15, 2021
54a9331
Switching to app config
craig-rueda Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion superset/migrations/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# under the License.
import logging
from logging.config import fileConfig
from os import getenv
from typing import List

from alembic import context
Expand All @@ -31,7 +32,9 @@

# Interpret the config file for Python logging.
# This line sets up loggers basically.
fileConfig(config.config_file_name)
if not getenv("ALEMBIC_SKIP_LOG_CONFIG"):
# Skip loading logger config if the user has this envvar set
fileConfig(config.config_file_name)
logger = logging.getLogger("alembic.env")

DATABASE_URI = current_app.config["SQLALCHEMY_DATABASE_URI"]
Expand Down