Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process color scheme configs correctly #17786

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

suddjian
Copy link
Member

SUMMARY

Loading custom sequential color schemes was failing because config objects were being treated as if they were instantiated classes.

TESTING INSTRUCTIONS

Add a custom sequential color scheme, and use it from a chart (sunburst chart uses sequential if you have both a primary and secondary metric)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #17786 (633df3d) into master (d9acb28) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17786      +/-   ##
==========================================
- Coverage   67.72%   67.72%   -0.01%     
==========================================
  Files        1605     1605              
  Lines       64207    64211       +4     
  Branches     6790     6790              
==========================================
+ Hits        43482    43484       +2     
- Misses      18869    18871       +2     
  Partials     1856     1856              
Flag Coverage Δ
javascript 54.82% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/packages/superset-ui-core/src/color/index.ts 100.00% <ø> (ø)
superset-frontend/src/setup/setupColors.ts 78.57% <71.42%> (-11.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9acb28...633df3d. Read the comment docs.

Copy link

@ryankubin ryankubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suddjian Looks as good as the day I watched you do it, sorry for the late review!

@suddjian suddjian merged commit de3d397 into apache:master Jan 4, 2022
@rosemarie-chiu
Copy link
Contributor

🏷 2022.1

rosemarie-chiu pushed a commit to preset-io/superset that referenced this pull request Jan 11, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.1 preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants