Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves spec files to the src folder - iteration 10 #17902

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Moves spec files to the src folder - iteration 10
  • Standardizes the extension of the test files

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #17902 (1e86d2e) into master (8ebec60) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17902      +/-   ##
==========================================
- Coverage   67.10%   67.09%   -0.01%     
==========================================
  Files        1609     1610       +1     
  Lines       64897    64913      +16     
  Branches     6866     6870       +4     
==========================================
+ Hits        43547    43556       +9     
- Misses      19484    19490       +6     
- Partials     1866     1867       +1     
Flag Coverage Δ
javascript 53.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/explore/fixtures.tsx 70.00% <ø> (ø)
superset-frontend/src/setup/setupColors.ts 73.33% <0.00%> (-8.49%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 66.18% <0.00%> (-0.97%) ⬇️
superset-frontend/src/middleware/asyncEvent.ts 69.46% <0.00%> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
...ntend/packages/superset-ui-core/src/color/index.ts 100.00% <0.00%> (ø)
...ashboard/components/gridComponents/ChartHolder.jsx 58.82% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <0.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/state.ts 73.33% <0.00%> (ø)
...end/src/common/hooks/useComponentDidMount/index.ts
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebec60...1e86d2e. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 647bbf1 into apache:master Jan 7, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* chore: Moves spec files to the src folder - iteration 10

* Fixes test

* Fixes lint problem

* Uses styledMount in test
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* chore: Moves spec files to the src folder - iteration 10

* Fixes test

* Fixes lint problem

* Uses styledMount in test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants