Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force_screenshot migration #17928

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

The migration was failing because chart_id was not present in the ReportSchedule model defined in the migration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  1. Create an alert.
  2. Downgrade to the version before the broken migration: superset db downgrade 31bb738bd1d2
  3. Upgrade the DB: superset db upgrade
  4. Verify that the column force_screenshot was added, and has the value true for the created alert:
SELECT force_screenshot FROM report_schedule;
 force_screenshot
------------------
 t
(1 row)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested a review from a team as a code owner January 5, 2022 01:58
@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #17928 (3c27a8a) into master (de3d397) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17928      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files        1609     1609              
  Lines       64903    64903              
  Branches     6866     6866              
==========================================
- Hits        43535    43531       -4     
- Misses      19502    19506       +4     
  Partials     1866     1866              
Flag Coverage Δ
hive 53.29% <ø> (ø)
mysql 82.18% <ø> (-0.01%) ⬇️
postgres 82.23% <ø> (-0.02%) ⬇️
presto 53.13% <ø> (ø)
python 82.67% <ø> (-0.02%) ⬇️
sqlite 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 89.13% <0.00%> (-2.18%) ⬇️
superset/common/query_object.py 95.08% <0.00%> (-0.55%) ⬇️
superset/reports/commands/execute.py 90.90% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3d397...3c27a8a. Read the comment docs.

@betodealmeida betodealmeida merged commit 4479fc9 into apache:master Jan 5, 2022
@rosemarie-chiu
Copy link
Contributor

🏷 2022.1

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jan 5, 2022
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Jan 6, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset:2022.1 size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants