Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update clickhouse.mdx #17937

Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix(docs): update clickhouse.mdx #17937

merged 1 commit into from
Jan 7, 2022

Conversation

rfraposa
Copy link
Contributor

@rfraposa rfraposa commented Jan 5, 2022

There is a contradiction on this page - the requirements show clickhouse-sqlalchemy and then there is this sentence stating that the recommended connector is sqlalchemy-clickhouse, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

There is a contradiction on this page - the requirements show `clickhouse-sqlalchemy` and then there is this sentence stating that the recommended connector is `sqlalchemy-clickhouse`, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I thought we had changed all references a while back, but it seems this had slipped through the cracks.

@villebro villebro merged commit c95d6bf into apache:master Jan 7, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
There is a contradiction on this page - the requirements show `clickhouse-sqlalchemy` and then there is this sentence stating that the recommended connector is `sqlalchemy-clickhouse`, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
There is a contradiction on this page - the requirements show `clickhouse-sqlalchemy` and then there is this sentence stating that the recommended connector is `sqlalchemy-clickhouse`, which is somewhat of an abandoned driver that is not seeing any activity in Github. I would suggest either removing the sentence about "recommended connector" or changing the link (as I have done in this PR).
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants