Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow sqla docs to use supersettext #18585

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Feb 4, 2022

SUMMARY

This pr is to allow SupersetText module texts to take precedent when it exits in the database connection modal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson marked this pull request as ready for review February 7, 2022 17:47
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #18585 (671151f) into master (9c3205b) will increase coverage by 0.02%.
The diff coverage is 78.72%.

❗ Current head 671151f differs from pull request most recent head 1cd1d32. Consider uploading reports for the commit 1cd1d32 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18585      +/-   ##
==========================================
+ Coverage   66.27%   66.30%   +0.02%     
==========================================
  Files        1594     1595       +1     
  Lines       62621    62632      +11     
  Branches     6311     6309       -2     
==========================================
+ Hits        41505    41529      +24     
+ Misses      19467    19453      -14     
- Partials     1649     1650       +1     
Flag Coverage Δ
javascript 51.37% <78.26%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ListView/ListView.tsx 96.25% <ø> (ø)
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.94% <0.00%> (+0.05%) ⬆️
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 65.51% <ø> (+1.00%) ⬆️
.../controls/DndColumnSelectControl/OptionWrapper.tsx 63.41% <ø> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 52.23% <0.00%> (-0.30%) ⬇️
superset/charts/api.py 85.93% <ø> (ø)
superset/charts/schemas.py 99.34% <ø> (ø)
superset/dashboards/api.py 92.54% <ø> (ø)
superset/databases/api.py 93.99% <ø> (ø)
superset/datasets/api.py 91.89% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3205b...1cd1d32. Read the comment docs.

@hughhhh hughhhh merged commit 4e2bdd4 into apache:master Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
* chore: allow sqla docs to use supersettext

* Update SqlAlchemyForm.tsx
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants