Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests-backend): migrate snowflake and sqlite to unit tests #18854

Merged
merged 2 commits into from
Feb 23, 2022
Merged

chore(tests-backend): migrate snowflake and sqlite to unit tests #18854

merged 2 commits into from
Feb 23, 2022

Conversation

corbinrobb
Copy link
Contributor

SUMMARY

Migrating the snowflake and sqlite db engine spec integration tests into unit tests

Requested in #18747

These were straightforward so I don't have anything to say about my rationale or decisions

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

run pytest ./db_engine_specs/test_sqlite.py
and
run pytest ./db_engine_specs/test_snowflake.py

ADDITIONAL INFORMATION

  • Has associated issue: List which integration tests can easily be converted to unit tests #18747
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the Superset-Community-Partners Preset community partner program participants label Feb 22, 2022
@corbinrobb
Copy link
Contributor Author

@betodealmeida

villebro
villebro approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks so much for this! One more nail in the legacy test coffin! ⚰️

@lyndsiWilliams lyndsiWilliams merged commit 0ae1ca7 into apache:master Feb 23, 2022
@lyndsiWilliams lyndsiWilliams deleted the corbin/convert-integration-tests-to-unit branch February 23, 2022 17:11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@AAfghahi AAfghahi AAfghahi approved these changes

@lyndsiWilliams lyndsiWilliams lyndsiWilliams approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L Superset-Community-Partners Preset community partner program participants 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corbinrobb @villebro @AAfghahi @lyndsiWilliams @mistercrunch