Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove legacy SIP-15 interim logic/flags #18936

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Feb 24, 2022

SUMMARY

This PR removes the legacy SIP-15 interim logic/flags. Time range endpoints are no longer configurable and strictly adhere to the [start, end) paradigm, i.e., inclusive of the start and exclusive of the end.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@john-bodley john-bodley changed the title chore: Remove legacy SIP-15 logic chore: Remove legacy SIP-15 interim logic/flags Feb 24, 2022
@john-bodley john-bodley force-pushed the john-bodley--issue-18906 branch 2 times, most recently from a77b87d to 73663b7 Compare February 24, 2022 19:30
@john-bodley john-bodley marked this pull request as ready for review February 24, 2022 20:16
@john-bodley john-bodley requested a review from a team as a code owner February 24, 2022 20:16
@john-bodley john-bodley force-pushed the john-bodley--issue-18906 branch 3 times, most recently from 17bee7d to 19bd602 Compare February 24, 2022 21:54
@john-bodley john-bodley force-pushed the john-bodley--issue-18906 branch 5 times, most recently from 0df04df to 8249f09 Compare February 25, 2022 00:49
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #18936 (544a65d) into master (420a63f) will decrease coverage by 0.01%.
The diff coverage is 65.21%.

❗ Current head 544a65d differs from pull request most recent head 0c255d3. Consider uploading reports for the commit 0c255d3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18936      +/-   ##
==========================================
- Coverage   66.39%   66.37%   -0.02%     
==========================================
  Files        1640     1641       +1     
  Lines       63507    63475      -32     
  Branches     6415     6418       +3     
==========================================
- Hits        42165    42133      -32     
  Misses      19681    19681              
  Partials     1661     1661              
Flag Coverage Δ
hive 52.59% <90.00%> (+<0.01%) ⬆️
mysql 81.81% <90.00%> (-0.01%) ⬇️
postgres 81.86% <90.00%> (+<0.01%) ⬆️
presto 52.44% <100.00%> (+<0.01%) ⬆️
python 82.29% <100.00%> (+<0.01%) ⬆️
sqlite 81.55% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-chart-controls/src/sections/sections.tsx 100.00% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 36.36% <ø> (+0.36%) ⬆️
...ckages/superset-ui-core/src/query/extractExtras.ts 100.00% <ø> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 59.01% <ø> (ø)
...nd/src/dashboard/components/nativeFilters/utils.ts 46.66% <ø> (ø)
...et-frontend/src/explore/controlPanels/sections.tsx 85.71% <ø> (ø)
superset-frontend/src/explore/controls.jsx 31.57% <ø> (+0.54%) ⬆️
...d/src/filters/components/Time/TimeFilterPlugin.tsx 53.33% <ø> (-2.92%) ⬇️
superset/charts/schemas.py 99.33% <ø> (-0.01%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420a63f...0c255d3. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI pass.

@github-actions
Copy link
Contributor

⚠️ @john-bodley Your base branch master has just also updated superset/migrations.

Please consider rebasing your branch to avoid db migration conflicts.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

⚠️ @john-bodley Your base branch master has just also updated superset/migrations.

Please consider rebasing your branch to avoid db migration conflicts.

@john-bodley john-bodley added the risk:breaking-change Issues or PRs that will introduce breaking changes label Mar 3, 2022
@john-bodley john-bodley merged commit 26486d0 into apache:master Mar 3, 2022
serenajiang added a commit to serenajiang/incubator-superset that referenced this pull request Mar 31, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/XL 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants