chore: Change Sort by and Sort descending controls for Time-series Bar Chart

[geido]

SUMMARY

This PR hides the SERIES LIMIT SORT BY and SERIES LIMIT SORT DESCENDING when no SERIES LIMIT is set and viceversa.

There is an issue for which some controls are not properly cleared when hidden. This issue is already affecting master and will be fixed in a separate PR.

AFTER

DEV.Quarterly.Sales.By.Product.Line.1.mp4

TESTING INSTRUCTIONS

1. Open a Time-Series Bar Chart
2. Add a SERIES LIMIT
3. Make sure the SERIES LIMIT SORT BY and SERIES LIMIT SORT DESCENDING appear
4. Remove the SERIES LIMIT
5. Make sure the SERIES LIMIT SORT BY and SERIES LIMIT SORT DESCENDING do not appear

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #18950 (0e1ca34) into master (2cb3635) will increase coverage by 0.00%.
The diff coverage is 86.44%.

❗ Current head 0e1ca34 differs from pull request most recent head 8b76318. Consider uploading reports for the commit 8b76318 to get more accurate results

@@           Coverage Diff           @@
##           master   #18950   +/-   ##
=======================================
  Coverage   66.38%   66.39%           
=======================================
  Files        1640     1641    +1     
  Lines       63514    63516    +2     
  Branches     6418     6423    +5     
=======================================
+ Hits        42164    42171    +7     
+ Misses      19690    19685    -5     
  Partials     1660     1660           

Flag	Coverage Δ
javascript	51.00% <86.20%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...perset-ui-chart-controls/src/utils/D3Formatting.ts	100.00% <ø> (ø)
...reset-chart-deckgl/src/utilities/Shared_DeckGL.jsx	84.21% <ø> (ø)
...acy-preset-chart-deckgl/src/utilities/controls.jsx	11.11% <ø> (-8.89%)	⬇️
...s/legacy-preset-chart-nvd3/src/Bar/controlPanel.ts	16.66% <0.00%> (-83.34%)	⬇️
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx	100.00% <ø> (+4.16%)	⬆️
...c/SqlLab/components/RunQueryActionButton/index.tsx	50.00% <ø> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx	71.42% <ø> (ø)
...frontend/src/SqlLab/components/SaveQuery/index.tsx	57.89% <ø> (ø)
...rc/SqlLab/components/ScheduleQueryButton/index.tsx	19.23% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js	33.15% <ø> (ø)
... and 53 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb3635...8b76318. Read the comment docs.

[zhaoyongjie]

Hey, @geido. I tested it in my local environment. I found that we can't remove series order by metric after disabling series limit. Please look at the video:

should.remove.unused.measure.mov

[geido]

Hello @zhaoyongjie this is the problem that I am mentioning in the description as well. This issue is affecting master too and it requires more investigation. @stephenLYZ is working on it in a separate PR. Thanks!

[geido]

For reference, the problem mentioned above can also be reproduced from this PR #17726. The Sort descending will always be applied even when hidden

[zhaoyongjie]

Hello @zhaoyongjie this is the problem that I am mentioning in the description as well. This issue is affecting master too and it requires more investigation. @stephenLYZ is working on it in a separate PR. Thanks!

Thanks for the explanation. LGTM