Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(external-link): change the external link in creating chart dashboard #18982

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix(external-link): change the external link in creating chart dashboard #18982

merged 1 commit into from
Mar 1, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 1, 2022 •
edited
Loading

SUMMARY

The external link available on the Create Chart dialog is broken

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
Old Link: https://superset.apache.org/docs/creating-charts-dashboards/first-dashboard#adding-a-new-table
AFTER
New Link: https://superset.apache.org/docs/creating-charts-dashboards/creating-your-first-dashboard/#registering-a-new-table

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

villebro
villebro approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro merged commit 37752ce into apache:master Mar 1, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@prosdev0107 @villebro
fix(external-link): change the external link in creating chart dashbo…
fe0f1de 
…ard (#18982)

(cherry picked from commit 37752ce)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prosdev0107 @villebro @mistercrunch