Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard import holding issue #19112

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

The Dashboard Import UI hangs when the operation fails - no error message is thrown to let the user know about it.

Behavior before update
The operation hangs. However, if you monitor the Network tab on the browser’s developer tools, you can check that the import request fails with a 500 error (Internal Server Error).

Expected results
The operation should thrown an error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER
image

TESTING INSTRUCTIONS

  1. Create a simple Dashboard.
  2. Export it.
  3. Edit the ZIP file, deleting the datasets folder.
  4. Try to import this modified ZIP in another Workspace.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codemaster08240328 codemaster08240328 changed the title fix dashboard import holding issue fix: Dashboard import holding issue Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #19112 (a66d6fa) into master (11bf0d0) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master   #19112      +/-   ##
==========================================
- Coverage   66.59%   66.58%   -0.01%     
==========================================
  Files        1676     1677       +1     
  Lines       64191    64240      +49     
  Branches     6525     6538      +13     
==========================================
+ Hits        42746    42775      +29     
- Misses      19746    19766      +20     
  Partials     1699     1699              
Flag Coverage Δ
javascript 51.32% <85.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/hooks.ts 47.15% <0.00%> (ø)
superset-frontend/src/views/CRUD/utils.tsx 66.12% <100.00%> (+0.55%) ⬆️
...d/components/DashboardBuilder/DashboardBuilder.tsx 70.88% <0.00%> (-1.85%) ⬇️
...rontend/src/dashboard/components/DashboardGrid.jsx 62.50% <0.00%> (-0.55%) ⬇️
superset-frontend/src/showSavedQuery/index.jsx 0.00% <0.00%> (ø)
...rontend/src/dashboard/containers/DashboardGrid.jsx 100.00% <0.00%> (ø)
...ntend/packages/superset-ui-core/src/color/utils.ts 100.00% <0.00%> (ø)
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <0.00%> (ø)
...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/ReactWorldMap.jsx 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bf0d0...a66d6fa. Read the comment docs.

superset-frontend/src/views/CRUD/hooks.ts Outdated Show resolved Hide resolved
superset-frontend/src/views/CRUD/hooks.ts Outdated Show resolved Hide resolved
superset-frontend/src/views/CRUD/utils.tsx Outdated Show resolved Hide resolved
superset-frontend/src/views/CRUD/utils.tsx Outdated Show resolved Hide resolved
superset-frontend/src/views/CRUD/utils.tsx Outdated Show resolved Hide resolved
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything was addressed, aside from error display location, which we can tackle in a subsequent PR. There was also the issue of memoization that Diego found, if you want to capture that in a new ticket, @codemaster08240328

Thanks for the fix!

@rusackas rusackas merged commit e118b4d into apache:master Apr 6, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2022
* fix dashboard import holding issue

* resolve comment

(cherry picked from commit e118b4d)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.13

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* fix dashboard import holding issue

* resolve comment
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.13 size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants