Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up chart metadata config #19143

Merged
merged 9 commits into from
Mar 16, 2022
Merged

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Mar 14, 2022

SUMMARY

Removing the deprecated field turns out to have been a bit much. Separately, flattening the label object into two separate fields allows us to better specify defaults and overrides for things.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

tested both deprecation and labels, and they still work as before.
Screen Shot 2022-03-14 at 3 33 28 PM

TESTING INSTRUCTIONS

Set a plugin's metadata to have deprecated: true or label: ChartLabel.FEATURED and find it (or don't, if it's deprecated) in the viz picker.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

Thank you for the fixes here!

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #19143 (417cd0c) into master (981f09b) will decrease coverage by 0.00%.
The diff coverage is 57.14%.

❗ Current head 417cd0c differs from pull request most recent head 0de8cab. Consider uploading reports for the commit 0de8cab to get more accurate results

@@            Coverage Diff             @@
##           master   #19143      +/-   ##
==========================================
- Coverage   66.55%   66.55%   -0.01%     
==========================================
  Files        1646     1646              
  Lines       63617    63625       +8     
  Branches     6471     6475       +4     
==========================================
+ Hits        42340    42344       +4     
- Misses      19599    19602       +3     
- Partials     1678     1679       +1     
Flag Coverage Δ
javascript 51.26% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 87.09% <25.00%> (-0.48%) ⬇️
...superset-ui-core/src/chart/models/ChartMetadata.ts 100.00% <100.00%> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <100.00%> (ø)
...frontend/src/components/TimezoneSelector/index.tsx 93.93% <0.00%> (-3.04%) ⬇️
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <0.00%> (ø)
...reset-chart-deckgl/src/utilities/Shared_DeckGL.jsx 86.48% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981f09b...0de8cab. Read the comment docs.

@suddjian suddjian merged commit 3d66912 into apache:master Mar 16, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 18, 2022
* fix: clean up chart metadata config

* missed a spot

* missed another spot

* fix failing time-specific test

* can't call translation functions here

* Revert "fix failing time-specific test"

This reverts commit 3eeb8ab.

* skip problematic test

* extra import

(cherry picked from commit 3d66912)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.11

villebro pushed a commit that referenced this pull request Apr 3, 2022
* fix: clean up chart metadata config

* missed a spot

* missed another spot

* fix failing time-specific test

* can't call translation functions here

* Revert "fix failing time-specific test"

This reverts commit 3eeb8ab.

* skip problematic test

* extra import

(cherry picked from commit 3d66912)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 preset-io size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants