Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing keys in components inside lists #19161

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Components inside react lists must have their own unique keys.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@diegomedina248 diegomedina248 force-pushed the chore/add-missing-keys-in-components-inside-lists branch from a2adb93 to d78c249 Compare March 17, 2022 02:44
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #19161 (d78c249) into master (8d53db1) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master   #19161      +/-   ##
==========================================
- Coverage   66.54%   66.52%   -0.03%     
==========================================
  Files        1646     1645       -1     
  Lines       63630    63655      +25     
  Branches     6475     6484       +9     
==========================================
+ Hits        42343    42345       +2     
- Misses      19607    19629      +22     
- Partials     1680     1681       +1     
Flag Coverage Δ
javascript 51.26% <60.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 38.09% <ø> (ø)
...perset-frontend/src/views/components/MenuRight.tsx 65.71% <0.00%> (ø)
superset-frontend/src/views/components/Menu.tsx 58.97% <50.00%> (ø)
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx 74.74% <100.00%> (+0.25%) ⬆️
...d/src/SqlLab/components/QueryAutoRefresh/index.jsx 61.29% <0.00%> (-22.05%) ⬇️
...rontend/src/explore/components/EmbedCodeButton.jsx 55.00% <0.00%> (-11.67%) ⬇️
...ontend/src/components/URLShortLinkButton/index.jsx 93.75% <0.00%> (-6.25%) ⬇️
...rontend/src/dashboard/containers/DashboardPage.tsx 5.68% <0.00%> (-0.35%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 64.23% <0.00%> (-0.22%) ⬇️
...erset-frontend/src/components/AnchorLink/index.jsx 80.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d53db1...d78c249. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the patience and due diligence.

@rusackas rusackas merged commit 54f1b35 into apache:master Mar 21, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants