Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor import command #19216

Merged
merged 1 commit into from
Mar 17, 2022
Merged

chore: refactor import command #19216

merged 1 commit into from
Mar 17, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

Refactor two methods from ImportModelsCommand into functions, so they can be reused later on a new command.

This depends on #19215.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #19216 (377fba6) into master (d01fdad) will increase coverage by 14.36%.
The diff coverage is 97.14%.

❗ Current head 377fba6 differs from pull request most recent head 625b774. Consider uploading reports for the commit 625b774 to get more accurate results

@@             Coverage Diff             @@
##           master   #19216       +/-   ##
===========================================
+ Coverage   52.03%   66.40%   +14.36%     
===========================================
  Files        1646     1646               
  Lines       63635    63640        +5     
  Branches     6475     6475               
===========================================
+ Hits        33112    42257     +9145     
+ Misses      28843    19703     -9140     
  Partials     1680     1680               
Flag Coverage Δ
hive ?
mysql 81.88% <97.14%> (?)
postgres 81.92% <97.14%> (?)
presto ?
python 82.01% <97.14%> (+29.22%) ⬆️
sqlite 81.67% <97.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/commands/importers/v1/utils.py 93.50% <96.87%> (+50.02%) ⬆️
superset/commands/importers/v1/__init__.py 94.64% <100.00%> (+62.93%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/config.py 91.79% <0.00%> (+0.31%) ⬆️
superset/common/utils/query_cache_manager.py 89.41% <0.00%> (+1.17%) ⬆️
superset/initialization/__init__.py 90.72% <0.00%> (+1.71%) ⬆️
superset/extensions.py 93.90% <0.00%> (+2.43%) ⬆️
superset/charts/data/commands/get_data_command.py 100.00% <0.00%> (+3.70%) ⬆️
superset/databases/commands/exceptions.py 96.00% <0.00%> (+4.00%) ⬆️
superset/views/sql_lab.py 60.68% <0.00%> (+4.13%) ⬆️
... and 284 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01fdad...625b774. Read the comment docs.

@betodealmeida betodealmeida changed the base branch from export_related_flag to master March 16, 2022 23:04
@betodealmeida betodealmeida merged commit a4848a2 into master Mar 17, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the refactor_import_code branch March 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants