Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump storybook to 6.4.19, migrating config, and linting storybook config #19245

Merged
merged 3 commits into from
Mar 28, 2022
Merged

chore: bump storybook to 6.4.19, migrating config, and linting storybook config #19245

merged 3 commits into from
Mar 28, 2022

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Mar 17, 2022 •
edited
Loading

SUMMARY

Bumps storybook to the latest, which deprecated the -s option, so this moves that configuration to a new home.

Tweaking the Storybook config revealed that these files are checked for proper linting by CI, but the linter doesn't fix them, so I nabbed that too as bycatch.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a, no difference.

TESTING INSTRUCTIONS

Run the storybook, see how it runs :D

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #19245 (afd49b1) into master (aa5c80b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19245   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files        1670     1670           
  Lines       64397    64410   +13     
  Branches     6499     6503    +4     
=======================================
+ Hits        42992    43003   +11     
  Misses      19722    19722           
- Partials     1683     1685    +2
Flag Coverage Δ
hive 52.52% <ø> (ø)
javascript 51.32% <ø> (+0.01%) ⬆️
mysql 81.96% <ø> (ø)
postgres 82.01% <ø> (ø)
presto 52.37% <ø> (ø)
python 82.43% <ø> (ø)
sqlite 81.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 59.74% <0.00%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa5c80b...afd49b1. Read the comment docs.

@rusackas rusackas changed the title chore: bump storybook to 6.4.19 and reconfigure accordingly chore: bump storybook to 6.4.19, migrating config, and linting storybook config Mar 18, 2022
michael-s-molina
michael-s-molina approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit b689ac2 into master Mar 28, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@rusackas @villebro
chore: bump storybook to 6.4.19, migrating config, and linting storyb…
495b29a 
…ook config (#19245)

* chore: bump storybook to 6.4.19 and reconfigure accordingly

* now linting the storybook directory, since it gets validated by CI

* linting ✨

(cherry picked from commit b689ac2)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@rusackas @philipher29
chore: bump storybook to 6.4.19, migrating config, and linting storyb…
308e692 
…ook config (apache#19245)

* chore: bump storybook to 6.4.19 and reconfigure accordingly

* now linting the storybook directory, since it gets validated by CI

* linting ✨
@rusackas rusackas deleted the bump-storybook branch January 30, 2023 19:19
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@lyndsiWilliams lyndsiWilliams Awaiting requested review from lyndsiWilliams

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rusackas @michael-s-molina @mistercrunch @villebro