Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode #19362

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

In order to display the 'View Results' button in the history tab of the SQL Lab, the query must have a resultsKey.
When the query is executed in sync mode, that key was not properly propagated from the API to the FE, thus, the button did not appeared after execution.

The button did appeared once the running polling watching for queries updated, since that fetches fresh results from the api.

This PR forwards that key to make the button show for every successfully executed query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-03-24.at.17.16.06.mov

After:

Screen.Recording.2022-03-24.at.17.14.22.mov

TESTING INSTRUCTIONS

  1. Configure a database for sync mode
  2. Run queries in SQL Lab in that database
  3. Check query history

Ensure that, if the queries are successful, the 'View Results' button always displays.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #19362 (afab418) into master (a08f83b) will decrease coverage by 0.05%.
The diff coverage is 71.61%.

❗ Current head afab418 differs from pull request most recent head abff716. Consider uploading reports for the commit abff716 to get more accurate results

@@            Coverage Diff             @@
##           master   #19362      +/-   ##
==========================================
- Coverage   66.64%   66.58%   -0.06%     
==========================================
  Files        1674     1677       +3     
  Lines       64614    64238     -376     
  Branches     6502     6538      +36     
==========================================
- Hits        43061    42772     -289     
+ Misses      19868    19766     -102     
- Partials     1685     1700      +15     
Flag Coverage Δ
javascript 51.32% <53.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntrols/src/components/CertifiedIconWithTooltip.tsx 80.00% <ø> (ø)
...erset-ui-chart-controls/src/components/Tooltip.tsx 80.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...-chart-controls/src/sections/advancedAnalytics.tsx 33.33% <ø> (ø)
...omponents/ColumnConfigControl/ColumnConfigItem.tsx 0.00% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 36.19% <0.00%> (-0.35%) ⬇️
...perset-ui-chart-controls/src/utils/D3Formatting.ts 100.00% <ø> (ø)
...s/superset-ui-core/src/query/api/v1/handleError.ts 100.00% <ø> (ø)
...uperset-ui-core/src/query/types/AnnotationLayer.ts 100.00% <ø> (ø)
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <ø> (ø)
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08f83b...abff716. Read the comment docs.

@prosdev0107
Copy link
Contributor

LGTM!

@rusackas
Copy link
Member

LGTM!

@codemaster08240328 Please feel free to add a review so the PR gets a checkmark :)

@rusackas rusackas merged commit 6d5d03e into apache:master Apr 13, 2022
Gwitchr added a commit to Gwitchr/superset that referenced this pull request Apr 29, 2022
…in the history tab on sync mode (apache#19362)"

This reverts commit 6d5d03e.
rusackas pushed a commit that referenced this pull request May 2, 2022
…in the history tab on sync mode (#19362)" (#19906)

This reverts commit 6d5d03e.
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 2, 2022
…in the history tab on sync mode (apache#19362)" (apache#19906)

This reverts commit 6d5d03e.

(cherry picked from commit 1fa841e)
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…istory tab on sync mode (apache#19362)

* fix(sql lab): display the 'View Results' button in the history tab when running sync queries

* pr comment
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants