refactor: Removes the CSS files from the Heatmap plugin #19417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19417 +/- ##
==========================================
- Coverage 66.48% 66.48% -0.01%
==========================================
Files 1670 1671 +1
Lines 63968 63976 +8
Branches 6512 6510 -2
==========================================
+ Hits 42531 42532 +1
- Misses 19748 19753 +5
- Partials 1689 1691 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
1 similar comment
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://54.186.238.55:8080. Credentials are |
1 similar comment
|
@geido Ephemeral environment spinning up at http://54.186.238.55:8080. Credentials are |
geido
approved these changes
Mar 31, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* refactor: Removes the CSS files from the Heatmap plugin * Adds peer dependencies (cherry picked from commit ac6b2f2)
villebro
pushed a commit
that referenced
this pull request
Apr 4, 2022
* refactor: Removes the CSS files from the Heatmap plugin * Adds peer dependencies (cherry picked from commit ac6b2f2)
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* refactor: Removes the CSS files from the Heatmap plugin * Adds peer dependencies
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes the CSS files from the Heatmap plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.
ADDITIONAL INFORMATION