Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove wrong usage of font-size in ExploreViewContainer #19614

Merged
merged 2 commits into from
Apr 12, 2022
Merged

chore: Remove wrong usage of font-size in ExploreViewContainer #19614

merged 2 commits into from
Apr 12, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 8, 2022

SUMMARY

It removes an unnecessary font-size and fixes a className to match the right layout as detailed in #19099

BEFORE

Screen Shot 2022-04-08 at 14 38 43

AFTER

Screen Shot 2022-04-08 at 14 37 00

TESTING INSTRUCTIONS

  1. Open Explore
  2. Make sure the title of the left side panel has the right font-size and color

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #19614 (bb01d03) into master (83c3779) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19614      +/-   ##
==========================================
- Coverage   66.63%   66.44%   -0.19%     
==========================================
  Files        1680     1681       +1     
  Lines       64292    64397     +105     
  Branches     6564     6593      +29     
==========================================
- Hits        42839    42787      -52     
- Misses      19751    19926     +175     
+ Partials     1702     1684      -18     
Flag Coverage Δ
javascript 51.13% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/components/ExploreViewContainer/index.jsx 54.39% <ø> (ø)
...ts/nativeFilters/FilterBar/FilterControls/state.ts 0.00% <0.00%> (-75.00%) ⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx 6.59% <0.00%> (-53.85%) ⬇️
...tend/src/filters/components/Time/transformProps.ts 0.00% <0.00%> (-50.00%) ⬇️
...oard/components/nativeFilters/FilterCard/index.tsx 10.00% <0.00%> (-50.00%) ⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx 0.00% <0.00%> (-47.06%) ⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx 29.03% <0.00%> (-41.94%) ⬇️
...rset-frontend/src/filters/components/Time/index.ts 66.66% <0.00%> (-33.34%) ⬇️
...hboard/components/nativeFilters/FilterBar/utils.ts 53.84% <0.00%> (-23.08%) ⬇️
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <0.00%> (-14.29%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c3779...bb01d03. Read the comment docs.

@geido geido added the global:theming Related to theming Superset label Apr 8, 2022
@michael-s-molina
Copy link
Member

I'm not sure if we can make this change without changing the other headers together. The Dataset header looked disproportional when testing the application. It looks like those commit all or roll back all kinds of PR. What do you think @kasiazjc?

Screen Shot 2022-04-11 at 10 42 46 AM

Screen Shot 2022-04-11 at 10 43 45 AM

@geido
Copy link
Member Author

geido commented Apr 11, 2022

Just had a discussion with Kasia. All of those headers should be 12px and I am going to apply the changes to this PR

@geido
Copy link
Member Author

geido commented Apr 11, 2022

@michael-s-molina here is how it looks now

Screen Shot 2022-04-11 at 17 21 53

@michael-s-molina
Copy link
Member

Waaaaaay better! Thanks!

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 7b0b029 into apache:master Apr 12, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants