fix(table viz): correctly sort by multiple columns in a table #19920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent commit to sort alphanumeric columns via case insensitive comparison broke the multi-column sort option. React-table only sorts by the second (or third...) column if the first column matches. Since the alphanumeric sort only returned -1 or 1, it never would move to the subsequent columns when the earlier column values matched.
|
For reference, there's something on the react-table repo about this too |
Codecov Report
@@ Coverage Diff @@
## master #19920 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1714 1714
Lines 65052 65052
Branches 6722 6721 -1
=======================================
Hits 43279 43279
Misses 20061 20061
Partials 1712 1712
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@stephenLYZ @kgabryje anything else you think this needs? |
stephenLYZ
approved these changes
Jun 16, 2022
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 23, 2022
Recent commit to sort alphanumeric columns via case insensitive comparison broke the multi-column sort option. React-table only sorts by the second (or third...) column if the first column matches. Since the alphanumeric sort only returned -1 or 1, it never would move to the subsequent columns when the earlier column values matched. (cherry picked from commit a45d011)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 28, 2022
Recent commit to sort alphanumeric columns via case insensitive comparison broke the multi-column sort option. React-table only sorts by the second (or third...) column if the first column matches. Since the alphanumeric sort only returned -1 or 1, it never would move to the subsequent columns when the earlier column values matched. (cherry picked from commit a45d011)
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commit to sort alphanumeric columns via case insensitive
comparison broke the multi-column sort option. React-table only sorts
by the second (or third...) column if the first column matches.
Since the alphanumeric sort only returned -1 or 1, it never would move
to the subsequent columns when the earlier column values matched.
SUMMARY
prior commit only returned -1 or +1, resulting in a value of -1 when two rows had the same value for a given column.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Unsorted:
Sorted by Platform:
Sorted by Platform AND Global Sales (broken):
Sorted by Platform and Global Sales (fixed):
TESTING INSTRUCTIONS
I added a new test to check for properly sorting by multiple columns (using react-table's
ADDITIONAL INFORMATION