feat(dashboard): Rearrange items in chart header controls dropdown

[kgabryje]

SUMMARY

This PR rearranges and renames menu items in chart's controls dropdown on Dashboard.

• Grouped creating permalink and sending email in "Share" submenu
• Grouped exporting to CSV and downloading image in "Download" submenu
• Renamed "View chart in Explore" to "Edit chart"
• Renamed "Maximize/Minimize chart" to "Enter/Leave fullscreen"

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

CC @kasiazjc

[codecov]

Codecov Report

Merging #20049 (632f496) into master (1cd002e) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 632f496 differs from pull request most recent head 2e80a3f. Consider uploading reports for the commit 2e80a3f to get more accurate results

@@            Coverage Diff             @@
##           master   #20049      +/-   ##
==========================================
- Coverage   66.35%   66.35%   -0.01%     
==========================================
  Files        1713     1713              
  Lines       64102    64105       +3     
  Branches     6746     6748       +2     
==========================================
  Hits        42538    42538              
- Misses      19849    19851       +2     
- Partials     1715     1716       +1     

Flag	Coverage Δ
javascript	51.31% <66.66%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...BigNumber/BigNumberWithTrendline/transformProps.ts	46.96% <ø> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx	87.23% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx	60.60% <ø> (ø)
...ponents/controls/VizTypeControl/VizTypeGallery.tsx	87.09% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.tsx	63.85% <66.66%> (-2.40%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd002e...2e80a3f. Read the comment docs.

[kgabryje]

/testenv up

[github-actions]

@kgabryje Ephemeral environment spinning up at http://34.220.138.72:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

Thanks for the PR @kgabryje. I'm assuming that we will have another one coming for the dashboard options as well (to make them consistent).

I'm not sure if it's related but clicking on Download as image is raising the following exception:

[kasiazjc]

LGTM thank you 🙏

[kgabryje]

Thanks for the PR @kgabryje. I'm assuming that we will have another one coming for the dashboard options as well (to make them consistent).

I'm not sure if it's related but clicking on Download as image is raising the following exception:

Well spotted. The problem was that the menu renders in the chart holder in DOM tree, but submenu is attached to the body and there's no way to specify popup container. I changed the screenshot selector from relative to absolute (each chart holder has a class specific to chart id, so it's easy to use exact selector to grab correct chart)

[kgabryje]

I'm assuming that we will have another one coming for the dashboard options as well (to make them consistent).

Yep! That will happen when new Dashboard header (consistent with header in Explore) gets implemented

[michael-s-molina]

/testenv up

[github-actions]

@michael-s-molina Ephemeral environment spinning up at http://34.222.140.234:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.