Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CRUD): make to fix the dancing when crud view is on hover #20051

Merged
merged 2 commits into from
May 16, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented May 12, 2022

SUMMARY

[CRUD view] Dancing tooltip under Actions items

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

Screen.Recording.2022-05-12.at.12.21.53.AM.mov

AFTER:

crud-view-hover.mov

TESTING INSTRUCTIONS

Repro steps
1, Go to dashboard list/chart list/dataset list
2, move mouse under the edit or delete icon

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #20051 (1fe8059) into master (ee178f4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20051   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files        1712     1714    +2     
  Lines       64083    64112   +29     
  Branches     6744     6753    +9     
=======================================
+ Hits        42523    42544   +21     
- Misses      19847    19850    +3     
- Partials     1713     1718    +5     
Flag Coverage Δ
javascript 51.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/TableCollection/index.tsx 100.00% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.tsx 63.85% <0.00%> (-2.40%) ⬇️
...rc/explore/components/ExploreChartHeader/index.jsx 51.35% <0.00%> (-1.99%) ⬇️
...ponents/controls/ControlPopover/ControlPopover.tsx 89.09% <0.00%> (-0.66%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.33% <0.00%> (-0.37%) ⬇️
superset-frontend/src/components/Tabs/Tabs.tsx 95.83% <0.00%> (ø)
superset-frontend/src/views/components/SubMenu.tsx 86.20% <0.00%> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.10% <0.00%> (ø)
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 38.54% <0.00%> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 57.89% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee178f4...1fe8059. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.89.181.55:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit 1c3c3ae into apache:master May 16, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

hiboyang pushed a commit to datapunchorg/superset that referenced this pull request May 19, 2022
…#20051)

* fix(CRUD): make to fix the dancing when crud view is on hover

* fix(CRUD): make to restore font size property
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…#20051)

* fix(CRUD): make to fix the dancing when crud view is on hover

* fix(CRUD): make to restore font size property
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants