Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prevent dataset edit modal closing on click-away in edit mode #20278

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

reesercollins
Copy link
Contributor

@reesercollins reesercollins commented Jun 6, 2022

SUMMARY

When editing a dataset in superset, if you click away while editing, you lose all your progress. This change prevents the modal from closing when clicking outside its boundary when you're in edit mode.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

2022-06-06.09-41-52.mp4

TESTING INSTRUCTIONS

  1. Open the edit dataset modal
  2. Click outside the modal boundary. It should close
  3. Re-open the edit dataset modal
  4. Click the lock icon to enable editing mode
  5. Click outside the modal boundary. It should not close.

ADDITIONAL INFORMATION

  • Has associated issue: Prevent dataset edit modal closing on click-away in edit mode #20279
  • Required feature flags: DISABLE_DATASET_SOURCE_EDIT: False
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #20278 (bd1c798) into master (77e326f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bd1c798 differs from pull request most recent head 5d0d5c6. Consider uploading reports for the commit 5d0d5c6 to get more accurate results

@@           Coverage Diff           @@
##           master   #20278   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files        1729     1729           
  Lines       64904    64906    +2     
  Branches     6842     6842           
=======================================
+ Hits        43262    43264    +2     
  Misses      19893    19893           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Modal/Modal.tsx 88.05% <ø> (ø)
...end/src/components/Datasource/DatasourceEditor.jsx 65.33% <100.00%> (+0.13%) ⬆️
...tend/src/components/Datasource/DatasourceModal.tsx 69.76% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e326f...5d0d5c6. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.90.79.227:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

Looks/works great! Thanks for this!

@rusackas rusackas merged commit 498987a into apache:master Jun 15, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@reesercollins reesercollins deleted the feature/CLDN-563-upstream branch June 15, 2022 20:44
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants