Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update Edit Dashboard side panel tabs #20337

Conversation

codyml
Copy link
Member

@codyml codyml commented Jun 9, 2022

SUMMARY

Reorders/renames tabs for clarity, so Charts is first/default Components is instead named Layout Elements. Adds tests for BuilderComponentPane and relocates component and test files to meet file hierarchy recommendations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

before

After

after

TESTING INSTRUCTIONS

Unit test:

cd superset-frontend
npm run test -- src/dashboard/components/BuilderComponentPane/BuilderComponentPane.test.tsx

Note: despite passing, running test shows lots of console warning/errors – any idea why?

Manual check: check that clicking "Edit Dashboard" opens panel with Chart tab first and selected by default and Layout Elements tab second.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @codyml! I left some comments and tagged some wiki pages with common rules that we use 😉

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #20337 (b1cb411) into master (07b4a71) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #20337      +/-   ##
==========================================
+ Coverage   66.64%   66.67%   +0.02%     
==========================================
  Files        1738     1738              
  Lines       65056    65056              
  Branches     6885     6885              
==========================================
+ Hits        43356    43375      +19     
+ Misses      19953    19935      -18     
+ Partials     1747     1746       -1     
Flag Coverage Δ
javascript 51.67% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard/components/BuilderComponentPane/index.tsx 78.94% <0.00%> (ø)
...oard/components/gridComponents/new/NewMarkdown.jsx 0.00% <0.00%> (-100.00%) ⬇️
...c/dashboard/components/dnd/AddSliceDragPreview.jsx 60.00% <0.00%> (+10.00%) ⬆️
...t-frontend/src/dashboard/components/SliceAdder.jsx 76.47% <0.00%> (+10.29%) ⬆️
...et-frontend/src/dashboard/actions/sliceEntities.js 53.84% <0.00%> (+38.46%) ⬆️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b4a71...b1cb411. Read the comment docs.

@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://54.185.222.195:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding a test and also for adjusting the folder structure!

@codyml codyml force-pushed the codyml/sc-47191/default-to-charts-in-dashboard-edit-mode branch from f6fe0c0 to b1cb411 Compare June 10, 2022 14:50
@codyml codyml changed the title [WIP] chore(dashboard): update Edit Dashboard side panel tabs chore(dashboard): update Edit Dashboard side panel tabs Jun 10, 2022
@michael-s-molina michael-s-molina merged commit d0165b6 into apache:master Jun 10, 2022
@codyml codyml deleted the codyml/sc-47191/default-to-charts-in-dashboard-edit-mode branch June 10, 2022 16:04
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants