Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress translation warning in jest #20404

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Suppress the "Duplicate translation" warning message in jest processor. test this PR by

npx jest src/explore/controlUtils/standardizedFormData.test.tsx

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

Before

image

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20404 (df6a2d0) into master (c79b0d6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head df6a2d0 differs from pull request most recent head 4efc210. Consider uploading reports for the commit 4efc210 to get more accurate results

@@            Coverage Diff             @@
##           master   #20404      +/-   ##
==========================================
- Coverage   66.72%   66.70%   -0.02%     
==========================================
  Files        1740     1739       -1     
  Lines       65175    65136      -39     
  Branches     6895     6897       +2     
==========================================
- Hits        43486    43452      -34     
+ Misses      19940    19931       -9     
- Partials     1749     1753       +4     
Flag Coverage Δ
javascript 51.75% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/superset-ui-core/src/translation/Translator.ts 100.00% <100.00%> (ø)
...tend/plugins/plugin-chart-echarts/src/controls.tsx 63.33% <0.00%> (-9.40%) ⬇️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 33.33% <0.00%> (-6.67%) ⬇️
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 33.33% <0.00%> (-6.67%) ⬇️
superset/common/query_object_factory.py 87.50% <0.00%> (-5.00%) ⬇️
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 28.57% <0.00%> (-4.77%) ⬇️
...chart-controls/src/shared-controls/dndControls.tsx 26.92% <0.00%> (-1.38%) ⬇️
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 34.48% <0.00%> (-1.24%) ⬇️
...tend/src/components/Datasource/CollectionTable.tsx 80.53% <0.00%> (-0.34%) ⬇️
superset/db_engine_specs/presto.py 88.70% <0.00%> (-0.33%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79b0d6...4efc210. Read the comment docs.

@@ -81,3 +81,5 @@ setupSupersetClient();
jest.mock('src/hooks/useTabId', () => ({
useTabId: () => 1,
}));

process.env.WEBPACK_MODE = 'test';
Copy link
Member Author

@zhaoyongjie zhaoyongjie Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the environment variable WEBPACK_MODE was defined at webpack.config.js. add a new value test to determine if it is in the Jest process.

@zhaoyongjie zhaoyongjie added the hold:testing! On hold for testing label Jun 17, 2022
@zhaoyongjie zhaoyongjie removed the hold:testing! On hold for testing label Jun 21, 2022
Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 9fad26f into apache:master Jun 21, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 28, 2022
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants