-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add name, description and non null tables to RLS #20432
feat: add name, description and non null tables to RLS #20432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20432 +/- ##
==========================================
- Coverage 66.70% 66.57% -0.13%
==========================================
Files 1739 1739
Lines 65153 65166 +13
Branches 6899 6899
==========================================
- Hits 43462 43387 -75
- Misses 19938 20026 +88
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
# Set initial default names make sure we can have unique non null values | ||
all_rls = session.query(RowLevelSecurityFilter).all() | ||
for rls in all_rls: | ||
rls.name = f"rls{rls.id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe?
rls.name = f"rls{rls.id}" | |
rls.name = f"rls_{rls.id}" |
* feat: add name, description and non null tables to RLS * add validation * add and fix tests * fix sqlite migration * improve default value for name
SUMMARY
Add the following changes and improvements to Row Level Security:
List view
Add view, when adding a new RLS with an already existing name
Add view, validate at least one dataset is associated
cc @altef
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION