chore: update text for dbconn modal

[pkdotson]

SUMMARY

This pr updates the dbconnection modal text after user successfully connects to database.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

after

TESTING INSTRUCTIONS

Go to db connection modal and connect database. User should see updated text.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20773 (47a21c0) into master (460b213) will decrease coverage by 0.01%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master   #20773      +/-   ##
==========================================
- Coverage   66.35%   66.33%   -0.02%     
==========================================
  Files        1766     1767       +1     
  Lines       67124    67165      +41     
  Branches     7129     7145      +16     
==========================================
+ Hits        44541    44555      +14     
- Misses      20759    20782      +23     
- Partials     1824     1828       +4     

Flag	Coverage Δ
javascript	52.09% <22.22%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx	66.66% <ø> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx	31.52% <12.50%> (-0.23%)	⬇️
...c/views/CRUD/data/database/DatabaseModal/styles.ts	76.69% <100.00%> (+0.22%)	⬆️
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx	31.25% <0.00%> (-4.47%)	⬇️
...dashboard/components/AddSliceCard/AddSliceCard.tsx	65.90% <0.00%> (-1.54%)	⬇️
...BigNumber/BigNumberWithTrendline/transformProps.ts	45.45% <0.00%> (-1.52%)	⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx	67.60% <0.00%> (-1.41%)	⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts	54.65% <0.00%> (-1.31%)	⬇️
...mponents/controls/AnnotationLayerControl/index.jsx	9.67% <0.00%> (-0.50%)	⬇️
...frontend/src/SqlLab/components/ResultSet/index.tsx	50.69% <0.00%> (-0.35%)	⬇️
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[eschutho]

/testenv up

[github-actions]

@eschutho Ephemeral environment spinning up at http://54.191.17.248:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[eschutho]

A few more small design nits:
Can you change the line height on the subtext (Create a dataset to start visualizing...) to 17px per the mocks?
Maybe just check with design about the color of the buttons, too? It looks darker to me in the mocks.

Also, when I click the back button on that screen, I still see the buttons:

[yousoph]

cc @jess-dillard if you have any feedback to add

[yousoph]

• The button text on the Create Dataset and Query Data in SQL Lab doesn't look centered - there's too much space on the right side of the text - can you please double check if you're using the secondary button component? The spacing should be correct on the component
• Mocks say "begin visualizing" rather than "start visualizing" on the subheader text
• Typo - "to to query your data" with an extra "to"
  (Button color looks ok)

I noticed that the X button and the close button on the Dataset creation modal don't work when I am linked to it from the database connection screen, but they work normally when you open the modal from the CRUD view:

When clicking either of the buttons from the database connection success screen, the header/subheader disappeared and buttons jumped to the top of the modal and a loading state showed up on the modal. The modal shouldn't be moving when the screen is refreshing.

[eschutho]

@pkdotson, yes correct the font is 14px/17px for font size and line height. I think it's the line height that needs to be adjusted just a tweak on the Create a dataset to start visualizing... text. Thanks!

[eschutho]

just some style feedback

[pkdotson]

/testenv up

[github-actions]

@pkdotson Ephemeral environment spinning up at http://54.218.88.203:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.