Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make dependabot upgrade package.json + add more package.json files #20920

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

Dependabot has been bumping things in package-lock.json, but this could get nuked in a number of ways. This versioning-strategy flag SHOULD tell it to update package.json

Also, there were a couple of package.json files being skipped by dependabot (stuff for the Global Async Queries) so I've added those here for good measure.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

Let's, uhhh, see if it works?

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #20920 (b06c1cf) into master (06d0539) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20920   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1758     1758           
  Lines       67039    67039           
  Branches     7116     7116           
=======================================
  Hits        44457    44457           
  Misses      20752    20752           
  Partials     1830     1830           
Flag Coverage Δ
hive 53.25% <ø> (ø)
javascript 52.01% <ø> (ø)
mysql 81.00% <ø> (ø)
postgres 81.07% <ø> (ø)
presto 53.15% <ø> (ø)
python 81.55% <ø> (ø)
sqlite 79.67% <ø> (ø)
unit 50.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@eric-briscoe eric-briscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rusackas rusackas merged commit 755f654 into master Aug 4, 2022
@rusackas rusackas deleted the dependabot-config branch August 4, 2022 17:52
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants