fix: No back button in save dataset modal #20964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
approved these changes
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #20964 +/- ##
==========================================
- Coverage 66.38% 66.37% -0.01%
==========================================
Files 1766 1767 +1
Lines 67225 67231 +6
Branches 7137 7138 +1
==========================================
Hits 44625 44625
- Misses 20774 20779 +5
- Partials 1826 1827 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lyndsiWilliams
requested changes
Aug 3, 2022
AAfghahi
force-pushed
the
arash.afghahi/sc-54452/sql-lab-back-button-on-save-overwrite-modal
branch
from
3bad98c
to
0ee1a02
Compare
lyndsiWilliams
approved these changes
Aug 3, 2022
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 4, 2022
* back button fix * fixed test (cherry picked from commit eb5369f)
mistercrunch
added
🏷️ bot
mistercrunch
deleted the
arash.afghahi/sc-54452/sql-lab-back-button-on-save-overwrite-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We only want the back button to appear when a user has already selected the dataset that they are going to over write and are in the confirmation portion of the model.
This adds a line of logic to get to that effect.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-08-03.at.3.55.19.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION