Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds drill to detail context menu to Table #21168

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds drill-to-detail context menu to Table chart when right-clicking on the rows. The context menu is only displayed if the table contains aggregated data.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-23.at.3.27.53.PM.mov

TESTING INSTRUCTIONS

1 - You should be able to right-click on the rows in a table with aggregated data.
2 - Check the value and formatted value when right-clicking
3 - You should NOT be able to right-click on the rows in a table with raw data.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #21168 (cbcd6a9) into master (859b6d2) will decrease coverage by 0.02%.
The diff coverage is 9.09%.

❗ Current head cbcd6a9 differs from pull request most recent head d637c45. Consider uploading reports for the commit d637c45 to get more accurate results

@@            Coverage Diff             @@
##           master   #21168      +/-   ##
==========================================
- Coverage   66.39%   66.36%   -0.03%     
==========================================
  Files        1781     1781              
  Lines       67901    67930      +29     
  Branches     7246     7255       +9     
==========================================
  Hits        45085    45085              
- Misses      20954    20982      +28     
- Partials     1862     1863       +1     
Flag Coverage Δ
javascript 52.27% <9.09%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <ø> (ø)
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 34.48% <0.00%> (-0.92%) ⬇️
...tend/plugins/plugin-chart-table/src/TableChart.tsx 40.46% <0.00%> (-1.46%) ⬇️
...d/plugins/plugin-chart-table/src/transformProps.ts 64.44% <100.00%> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.07% <0.00%> (ø)
...s/plugin-chart-echarts/src/Gauge/transformProps.ts 76.92% <0.00%> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <0.00%> (ø)
.../plugin-chart-echarts/src/Funnel/transformProps.ts 71.73% <0.00%> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <0.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido
Copy link
Member

geido commented Aug 26, 2022

/testenv up FEATURE_DRILL_TO_DETAIL=true

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.191.215.56:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@michael-s-molina michael-s-molina merged commit 68fa4d2 into apache:master Aug 26, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants