Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): reverts #21141 #21174

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

This reverts #21141 because of initial database selection has gone.
I'll work on database selector side effect clean up and then re-merge this.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2022-08-23 at 9 05 33 PM

After:

Screen Shot 2022-08-23 at 9 05 42 PM

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark
Copy link
Member Author

@ktmud when you have a chance, please stamp and merge this revert.

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #21174 (d8d7e73) into master (ed6212a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21174   +/-   ##
=======================================
  Coverage   66.39%   66.40%           
=======================================
  Files        1781     1781           
  Lines       67874    67874           
  Branches     7239     7239           
=======================================
+ Hits        45067    45069    +2     
+ Misses      20949    20946    -3     
- Partials     1858     1859    +1     
Flag Coverage Δ
javascript 52.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/TableSelector/index.tsx 78.26% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 61.37% <0.00%> (+0.26%) ⬆️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 50.00% <0.00%> (+1.51%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ktmud ktmud merged commit 53de94c into apache:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants