Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds drill to detail context menu to Pivot Table #21198

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds drill-to-detail context menu to Pivot Table chart when right-clicking on the cells. It also improves the context menu positioning for the other supported chart types.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-25.at.10.04.57.AM.mov

TESTING INSTRUCTIONS

Check the video for test instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
1 nitpick about useCallback and 1 cosmetic question/suggestion - should we use a different cursor to indicate that the cells are clickable? Maybe a "normal" one (pointer would suggest left-click instead of right-click)?

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #21198 (66335dd) into master (53de94c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21198      +/-   ##
==========================================
- Coverage   66.40%   66.37%   -0.03%     
==========================================
  Files        1781     1781              
  Lines       67874    67913      +39     
  Branches     7239     7254      +15     
==========================================
+ Hits        45069    45077       +8     
- Misses      20946    20974      +28     
- Partials     1859     1862       +3     
Flag Coverage Δ
javascript 52.27% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx 0.00% <0.00%> (ø)
...nd/plugins/plugin-chart-echarts/src/Graph/types.ts 100.00% <ø> (ø)
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <0.00%> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Treemap/EchartsTreemap.tsx 0.00% <0.00%> (ø)
...ns/plugin-chart-echarts/src/utils/eventHandlers.ts 0.00% <0.00%> (ø)
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
...gin-chart-pivot-table/src/plugin/transformProps.ts 42.30% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
Copy link
Member Author

Looks great! 1 nitpick about useCallback and 1 cosmetic question/suggestion - should we use a different cursor to indicate that the cells are clickable? Maybe a "normal" one (pointer would suggest left-click instead of right-click)?

That's a good question. I'll bring it to the team and if we decide to use a specific cursor then I'll do it in a follow-up because I need to change all plugins.

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@michael-s-molina michael-s-molina merged commit 859b6d2 into apache:master Aug 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants