Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes error caused by step id placed in wrong location #21226

Merged
merged 2 commits into from
Aug 28, 2022
Merged

fix: Fixes error caused by step id placed in wrong location #21226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dd5522
Update chromatic PR action to have access to Job outputs
eric-briscoe Aug 26, 2022
866a5a6
Fixes error where step ID was incorrect location
eric-briscoe Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/chromatic-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ jobs:
chromatic-deployment:
# Operating System
runs-on: ubuntu-latest
# define outputs that can be used in the storybook-link-comment job
outputs:
storybookUrl: ${{ steps.chromatic-deploy.outputs.storybookUrl }}
buildUrl: ${{ steps.chromatic-deploy.outputs.buildUrl }}
# Job steps
steps:
- uses: actions/checkout@v1
Expand All @@ -50,7 +54,7 @@ jobs:
working-directory: superset-frontend
# 👇 Build and publish Storybook to Chromatic
- name: Build and publish Storybook to Chromatic
id: chromatic-pr
id: chromatic-deploy
uses: chromaui/action@v1
# Required options for the Chromatic GitHub Action
with:
Expand All @@ -76,5 +80,5 @@ jobs:
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }}. Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }} '
body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }} Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }}'
})