Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table content disappears when switching between tabs #21251

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix: Table content disappears when switching between tabs #21251

merged 1 commit into from
Aug 31, 2022

Conversation

EugeneTorap
Copy link
Contributor

@EugeneTorap EugeneTorap commented Aug 30, 2022

The issue appears after when we merged #21136 PR

SUMMARY

BEFORE SCREENSHOTS OR ANIMATED GIF

186693377-56c68591-98e1-47f8-a39e-b2cf1801d151.mov

AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #21251 (e29290d) into master (0c43190) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #21251   +/-   ##
=======================================
  Coverage   66.45%   66.46%           
=======================================
  Files        1784     1784           
  Lines       68165    68164    -1     
  Branches     7265     7265           
=======================================
+ Hits        45302    45304    +2     
+ Misses      20994    20991    -3     
  Partials     1869     1869           
Flag Coverage Δ
javascript 52.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/FilterableTable/index.tsx 72.63% <100.00%> (+0.29%) ⬆️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.37% <0.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido
Copy link
Member

geido commented Aug 30, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://35.87.135.143:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could repro this on master. The proposed solution seems to fix it. Thanks!

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@kgabryje kgabryje merged commit 0c87ff7 into apache:master Aug 31, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@EugeneTorap EugeneTorap deleted the fix/table-result-when-switching-tabs branch August 31, 2022 13:47
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants